[swift-3.0] Added -tools-directory option. (#2912) #4543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a path to look for ld (Darwin), or clang/binutils (Unix).
karwa
changed the title
|
CC @tkremenek, I think? |
|
@swift-ci test macOS |
|
Reviewed by me, for the record. Since all code changes are guarded under the new option flag, there shouldn't be effect on existing logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add -tools-directory to swift 3.0, to support cross-compiling. It's not the end of the story for cross-compiling with Swift, but it's what we've got for now.
Cherry-picked 20d9b96
Provides a path to look for ld (Darwin), or clang/binutils (Unix).