[Serialization] Ignore filesystem errors when loading modules. #4547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
I still can't find the Radar I was thinking of, but rdar://problem/23496758 may be the same issue. |
|
Build failed |
Instead, just go on to the next search path. This prevents a present-but-unreadable directory from leading to a module load failure, which happens when one user builds a module and another user loads it (even if those search paths aren't even being used). There might still be some other errors that would be useful to treat as "module found but invalid" rather than "module not found", but experience has shown that it's the wrong default. There is a Radar for this but I can't find it.
jrose-apple
force-pushed
the
load-permission-denied
branch
from
2eb07b9 to
001c8f6
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, just go on to the next search path. This prevents a present-but-unreadable directory from leading to a module load failure, which happens when one user builds a module and another user loads it (even if those search paths aren't even being used).
There might still be some other errors that would be useful to treat as "module found but invalid" rather than "module not found", but experience has shown that it's the wrong default.
There is a Radar for this but I can't find it.