[stdlib] rewrite optional handling using map #4552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gribozavr Is this kind of a change too much of a nitpick? |
| return nil | ||
| } | ||
| return String(_storage: stringBuffer) |
There was a problem hiding this comment.
I think this would actually be better as return stringBufferOptional.map { String(_storage: $0) }.
Nirma
changed the title
|
@gribozavr Thanks! That is a lot cleaner, I updated the pull request. How does it look now? |
|
LGTM, thanks! @swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought that rewriting the optional handling using map would make it a little bit
cleaner to read.
Hope its ok!