Metadata cache optimizations #4582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be an ObjC class wrapper. Fixes a longstanding bug that was exposed by my metadata cache improvements; previously it was hidden due to a chain of coincidences around the allocation of ObjCClassWrapper metadata.
no longer using it even in fallback code.
…urrentMap directly. Previously, these were all using MetadataCache. MetadataCache is a more heavyweight structure which acquires a lock before building the metadata. This is appropriate if building the metadata is very expensive or might have semantic side-effects which cannot be rolled back. It's also useful when there's a risk of re-entrance, since it can diagnose such things instead of simply dead-locking or infinitely recursing. However, it's necessary for structural cases like tuple and function types, and instead we can just use ConcurrentMap, which does a compare-and-swap to publish the constructed metadata and potentially destroys it if another thread successfully won the race. This is an optimization which we could not previously attempt. As part of this, fix tuple metadata uniquing to consider the label string correctly. This exposes a bug where the runtime demangling of tuple metadata nodes doesn't preserve labels; fix this as well.
|
@swift-ci Please smoke test and merge. |
kateinoigakukun
added a commit
that referenced
this pull request
Aug 31, 2022
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-submission of #4428 with a fix for a longstanding bug in a particular type-metadata query that was exposed by these changes to metadata allocation.