More metadata cache improvements #4589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetadataCache's allocator into it. The major functional change here is that MetadataCache will now use the slab allocator for tree nodes, but I also switched the Hashable conformances cache to use ConcurrentMap directly instead of a Lazy<ConcurrentMap<>>.
IIRC we never had any evidence that the performance impact of a separate allocator here was actually measurable, and it does come at a significant fragmentation cost because every single cache allocates at least a page of memory. Sharing that with the system allocator makes more sense, even if these allocations are typically permanent. This also means that standard memory-debugging tools will actually find problems with out-of-bounds accesses to metadata.
|
@swift-ci Please smoke test and merge. |
|
@swift-ci Please smoke test and merge |
|
(Not sure why it didn't trigger @rjmccall , But i kicked it off again) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few more metadata cache improvements.