[Parser] Preserve empty getter functions for indentation (3.0) #4592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Parser] Preserve empty getter functions to make sure indentation inside its body still works. rdar://28049927 * Using the consistent identifier even though they are identical.
|
@swift-ci Please test OS X platform |
|
LGTM. |
aaditya-chandrasekhar
pushed a commit
to val-verde/swift
that referenced
this pull request
Sep 30, 2022
[pull] swiftwasm-release/5.7 from release/5.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Parser] Preserve empty getter functions to make sure indentation inside its body still works. rdar://28049927
Explanation: Indentation is unavailable when users hit enter inside an empty block of getter function. The root cause is that parser dropped empty getter functions, leading SourceKit to believe there are nothing interesting at the indentation position. This patch starts to preserve empty getter functions.
Scope of issue: Low
Risk: Low
Reviewed By: Argyrios
Radar: rdar://28049927
Resolves SR-NNNN.