Skip to content

[FixCode] Add @escaping when overriding mismatch is because of it. #4593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2016
Merged

[FixCode] Add @escaping when overriding mismatch is because of it. #4593

merged 1 commit into from
Sep 2, 2016

Conversation

nkcsgexi
Copy link
Contributor

@nkcsgexi nkcsgexi commented Sep 1, 2016

[FixCode] Add @escaping when overriding mismatch is because of it. rdar://27814862

  • Explanation: With the change of default escaping behavior, users' existing code overriding
    objc functions may need to add @escaping to make the overriding match as before. This
    patch checks if an overriding mismatch is due to the lacking of @escaping and add
    it as a fixit.
  • Scope of issue: One fixit in overriding.
  • Reviewer: @jrose-apple
  • Risk: Low
  • Radar: rdar://27814862

…4273)

With the change of default escaping behavior, users' existing code overriding
objc functions may need to add @escaping to make the overriding match as before. This
patch checks if an overriding mismatch is due to the lacking of @escaping and add
it as a fixit.
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Sep 1, 2016

@swift-ci Please test OS X platform

@nkcsgexi nkcsgexi added this to the Swift 3.0 milestone Sep 1, 2016
@najacque
Copy link
Contributor

najacque commented Sep 2, 2016

@swift-ci Please ignore

[FixCode] Add @escaping when overriding mismatch is because of it. rdar://27814862

Explanation: With the change of default escaping behavior, users' existing code overriding
objc functions may need to add @escaping to make the overriding match as before. This
patch checks if an overriding mismatch is due to the lacking of @escaping and add
it as a fixit.

Scope of issue: One fixit in overriding.

Reviewer: @jrose-apple

Risk: Low

Radar: rdar://27814862

@najacque
Copy link
Contributor

najacque commented Sep 2, 2016

@swift-ci Please nominate

[FixCode] Add @escaping when overriding mismatch is because of it. rdar://27814862

Explanation: With the change of default escaping behavior, users' existing code overriding
objc functions may need to add @escaping to make the overriding match as before. This
patch checks if an overriding mismatch is due to the lacking of @escaping and add
it as a fixit.

Scope of issue: One fixit in overriding.

Reviewer: @jrose-apple

Risk: Low

Radar: rdar://27814862

@nkcsgexi nkcsgexi merged commit 9193abf into swiftlang:swift-3.0-branch Sep 2, 2016
@nkcsgexi nkcsgexi deleted the escaping-fixit-3.0 branch September 2, 2016 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants