Simplify initialization contexts in the AST #4601
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in a pattern binding decl.
…-local scopes. We were optimizing away unused pattern binding initializer contexts in both the parser and in semantic analysis, which led to a somewhat-unpredictable set of DeclContexts in the AST. Normalize everything by always creating these contexts.
ExprHandle is a relic from a horrible time when expressions made their way into the type system via default arguments. It's been unnecessary for a long time, so get rid of it.
…ault argument. As with pattern binding initializer contexts, we were trying to optimize away these contexts, leading to an unpredictable AST.
|
@swift-ci please smoke test and merge |
|
Ended up having to remove an unnecessary #include in LLDB. @swift-ci please smoke test Linux |
kateinoigakukun
added a commit
that referenced
this pull request
Aug 31, 2022
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies and normalizes the handling of initialization contexts in the AST, so parameter with default arguments and initializers of non-local pattern bindings have consistent, descriptive DeclContexts. Should be NFC.