Skip to content

[Coverage] Don't assign counter expressions to non-existent AST nodes… #4634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2016
Merged

[Coverage] Don't assign counter expressions to non-existent AST nodes… #4634

merged 1 commit into from
Sep 6, 2016

Conversation

vedantk
Copy link
Contributor

@vedantk vedantk commented Sep 6, 2016

… (NFC)

It shouldn't be possible to assign a counter expression to a non-existent (null) AST node. Doing so doesn't cause bugs, but it is wasteful.

@vedantk
Copy link
Contributor Author

vedantk commented Sep 6, 2016

@swift-ci Please test

@vedantk
Copy link
Contributor Author

vedantk commented Sep 6, 2016

@swift-ci Please smoke test OS X platform

@vedantk vedantk merged commit 0272536 into swiftlang:master Sep 6, 2016
@swift-ci
Copy link
Contributor

swift-ci commented Sep 6, 2016

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 3d9b908
Test requested by - @vedantk

@vedantk
Copy link
Contributor Author

vedantk commented Sep 7, 2016

I can't find any actual test failures in that log...

@vedantk vedantk deleted the coverage branch September 7, 2016 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vedantk @swift-ci