Allow @testable witnesses to satisfy protocol requirements. #4654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, if a would-be witness to a protocol requirement is only accessible because its module has been imported with '@testable', consider that "good enough" to satisfy the rule that a witness must be available everywhere the protocol and conforming type are both available (because those other contexts /could/ have done their own testable import). rdar://problem/28173654
Inspired by the previous commit. These are things we expect to keep working.
|
Looks good. |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Sep 7, 2016
…witnesses Allow @testable witnesses to satisfy protocol requirements. rdar://problem/28173654
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, if a would-be witness to a protocol requirement is only accessible because its module has been imported with
@testable, consider that "good enough" to satisfy the rule that a witness must be available everywhere the protocol and conforming type are both available (because those other contexts could have done their own testable import, and also shouldn't have to know that this file needed one to conform to the protocol).This re-enables some patterns that would have been allowed pre-SE-0025.
rdar://problem/28173654