[QoI] diagnose operator fixity attrs together; improve messages #4661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
force-pushed
the
diag-fixity
branch
from
3da8909 to
63a38a1
Compare
|
@swift-ci please smoke test |
|
@swift-ci smoke test linux |
DougGregor
requested changes
Sep 20, 2016
| @@ -4488,6 +4536,9 @@ Parser::parseDeclFunc(SourceLoc StaticLoc, StaticSpellingKind StaticSpelling, | |||
| GenericParams, BodyParams, Type(), FuncRetTy, | |||
| CurDeclContext); | |||
|
|
|||
| if (diagnoseOperatorFixityAttributes(*this, Attributes, FD)) | |||
| FD->setInvalid(); | |||
There was a problem hiding this comment.
It doesn't seem necessary to mark the whole declaration invalid, does it?
| } | ||
|
|
||
| if (diagnoseOperatorFixityAttributes(*this, Attributes, res)) | ||
| res->setInvalid(); |
There was a problem hiding this comment.
Same here: I don't think the whole operator declaration needs to be invalid.
There was a problem hiding this comment.
Fair enough — removed.
Previously, `infix` was not recognized as conflicting with `prefix` and `postfix`. We now offer to remove all but the first fixity attribute.
jtbandes
force-pushed
the
diag-fixity
branch
from
63a38a1 to
682ab47
Compare
|
@swift-ci please smoke test |
|
LGTM now, thanks! |
kateinoigakukun
added a commit
that referenced
this pull request
Aug 31, 2022
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue raised by @rintaro in #4628.
Previously,
infixwas not recognized as conflicting withprefixandpostfix. We now offer to remove all but the first fixity attribute.RFC:
I'm not sure
ParseDecl.cppis really the right place to check these attrs. I like the idea of havingTypeCheckAttr.cppcontain most of the attribute-verifying logic, but it's structured as a simple visitor which doesn't have the power to handle a few related attributes at the same time (without architectural changes). Maybe I'm missing something, but to me the current distinction between things inDiagnosticsSema.defand things inDiagnosticsParse.defseems somewhat arbitrary.Perhaps @DougGregor or someone else can provide a better alternative.
Before:
no error 😱 infix prefix operator ++ attribute 'postfix' cannot be combined with this attribute postfix prefix operator -- ^After:
error: 'prefix' contradicts previous modifier 'infix' infix prefix operator ++ ^~~~~~~ error: 'prefix' contradicts previous modifier 'postfix' postfix prefix operator -- ^~~~~~~