Changes for Android build of Foundation #4662
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this is entirely correct. Foundation is a target library but currently the build script only builds for the host. We only ever cross-compile for Android. Would it be possible to wait until we have restructured the build-script in to what @ddunbar calls a toolchain-based process? I hope to have a patch to do that soon. |
|
Sure, This change can keep and admittedly it is not a tidy one. I’m only keen for the swift-corelibs-foundation changes to be merged before they "go stale" |
|
@modocache Can you take a look? |
|
@slavapestov @modocache. This PR has probably been superceeded by work to bring the Android build into the fold @gonzalolarralde & others are doing at the moment. I should have closed this a while ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to build-script-imll to support build of Foundation with Android toolchain (see swiftlang/swift-corelibs-foundation#622) Simply passes additional Android specific options though to ninja script builder. Has been tested with Linux and OSX builds and doesn’t seem to break anything.