New SubstitutionMap data structure #4685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the TypeSubstitutionMap / ConformanceMap pair that has been appearing more and more lately.
This variant looks up conformances in a ConformanceMap rather than in the module. Avoiding blind conformance lookups is good for two reasons: - for general robustness at the SIL level, we prefer to use conformances handed to us by Sema rather than doing lookups, because that way we are guaranteed to receive a complete conformance. We've had several tricky bugs where SIL looks up a conformance that has not been forced by Sema, and this new variant of subst() defines the problem out of existence. - with property behaviors, the conformance cannot be looked up in this manner at all, so there we *must* always use a conformance map, if one is given. - the old API required passing in a ModuleDecl *, which is awkward.
SILType substitutions are still done with the old form, and until BoundGenericTypes hold conformances, we still have to pass around a ModuleDecl in a few places we really shouldn't, but one step at a time.
|
@swift-ci Please smoke test |
aaditya-chandrasekhar
pushed a commit
to val-verde/swift
that referenced
this pull request
Sep 30, 2022
[pull] swiftwasm-release/5.7 from release/5.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.