[sil-devirtualizer] Use a more advanced algorithm to figure out the exact types of instances #4756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xact types of instances - Look through BB arguments with multiple predecessors. - Provide a new helper function to figure out the exact type of the underlying object. It will be used by subsequent commits to improve the escape analysis.
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
| // The detected type of the underlying object. | ||
| SILType ResultType; | ||
| // Set of processed values. | ||
| llvm::SetVector<SILValue> Processed; |
There was a problem hiding this comment.
No need to be a SetVector as you don't iterate over the elements
There was a problem hiding this comment.
Yep. I meant SmallSet, but typed SetVector ;-)
There was a problem hiding this comment.
@eeckstein I addressed it in #4761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.