Small generics cleanups #4758
Merged
Small generics cleanups #4758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When applying substitutions to substitution lists in SIL, we would unpack the ArrayRef<Substitution> into a SubstitutionMap on each iteration over the original ArrayRef<Substitution>. Discourage this sort of thing by removing the API in question and refactoring surrounding code.
…eneric signatures
Don't look at the source locations, because they're fake; just make the generic parameter `Self` visible inside the body of the protocol instead.
Not quite ready to define extensions that make generic parameters concrete, but close.
|
@swift-ci Please test |
DougGregor
reviewed
Sep 14, 2016
| @@ -1439,6 +1439,13 @@ SourceRange ASTScope::getSourceRangeImpl() const { | |||
| return cast<NominalTypeDecl>(iterableDeclContext)->getBraces(); | |||
|
|
|||
| case ASTScopeKind::GenericParams: | |||
| // A protocol's generic parameter list is not written in source, and | |||
aaditya-chandrasekhar
pushed a commit
to val-verde/swift
that referenced
this pull request
Sep 30, 2022
[pull] swiftwasm-release/5.7 from release/5.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.