[Scope map] Miscellaneous improvements (and a hack) for unqualified name lookup #4770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test and merge |
While the use of a local property from within its own accessors is a bit dubious, Swift 3 only warned on it, so model the existing lookup behavior in the scope map.
…L mode. The integrated REPL does very funny things with source locations in source files, because it uses new buffers for each bit of code it parses, breaking all of the invariants of a source-based data structure like ASTScope.
…ified name lookup. When using the ASTScope-based unqualified name lookup, we might find things that are in scope but haven't been fully type-checked yet; allow us to perform type checking.
DeclContext::getSelfTypeInContext() returns null types in some cases of broken protocols. Hack around this in the ASTScope-based unqualified name lookup code for now, with a narrower hack than what the existing unqualified name lookup is doing (which is even *less* principled).
…ariables. Until the point where ASTScope-based unqualified name lookup is the default, unqualified name lookup can still find names declared *after* the source location. The 'hasType' check no longer makes sense, so actually check the source location of the entity we found.
DougGregor
force-pushed
the
scope-map-fixes
branch
from
8c8db1a to
4c45885
Compare
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces several fixes to match the way unqualified name lookup currently works (e.g., w.r.t. local computed properties), as well as improving bad source locations in the AST on ill-formed code.