Revert "[omit-needless-words] Fix a bug found by -Wunused-result" #4780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge |
|
Hey @DougGregor, I'm pulling this out for now since I haven't looked at the consequences. Do you want to do anything with this? I was really just interested in shutting up the -Wunused-result warning, and I have no opinion on the actual change. |
|
I can do before/after API dumps to see if this affects the SDK. |
|
It could still affect third-party code, too. (Either it does, in which case it might break somebody, or it doesn't, in which case it's making sure we get things right for code that hasn't been used in Swift yet.) |
kateinoigakukun
added a commit
that referenced
this pull request
Aug 31, 2022
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4776. This might impact imported API (d'oh, obviously). Pull it out for now.