Skip to content

Fix the SourceRange of an AssignExpr with an implicit source. #4792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2016
Merged

Fix the SourceRange of an AssignExpr with an implicit source. #4792

merged 2 commits into from
Sep 15, 2016

Conversation

jrose-apple
Copy link
Contributor

Fixed by Maxwell Swadling, unit test by me.

@jrose-apple
[unittests] Factor out TestContext helper for AST tests.
2fdd456 
This is used to set up a very simple AST context so that AST nodes
can be allocated as usual.

No functionality change.
@jrose-apple
Fix the SourceRange of an AssignExpr with an implicit source.
4ec661d 
Fixed by Maxwell Swadling, unit test by me.
@jrose-apple
Copy link
Contributor Author

@mxswd, does the test look correct here? Note that I only bothered to test cases where the = was also implicit and had no location.

@swift-ci Please smoke test

@jrose-apple
Copy link
Contributor Author

Also, was there a Radar associated with this?

@mxswd
Copy link
Contributor

mxswd commented Sep 15, 2016

@jrose-apple Looks good! Thanks Jordan! No radar.

@jrose-apple jrose-apple merged commit 55095ef into swiftlang:master Sep 15, 2016
@jrose-apple jrose-apple deleted the AssignExpr-SourceRange branch September 15, 2016 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrose-apple @mxswd