[Foundation overlay] Enable custom AnyHashable representation for NSMeasurement #4793
Conversation
|
@swift-ci please smoke test and merge |
|
@gribozavr , do you mind taking a look? |
| unit: UnitLength.kilometers) | ||
| let ah = AnyHashable(measurement) | ||
| expectTrue(type(of: ah.base) is Measurement.Type) | ||
| } |
There was a problem hiding this comment.
Please move the tests to test/stdlib/TestMeasurement.swift instead. Please follow the pattern in test_AnyHashableCreatedFromNSCalendar from test/stdlib/TestCalendar.swift.
DougGregor
force-pushed
the
custom-anyhashable-nsmeasurement
branch
from
7aa3a7e to
87ab304
Compare
…easurement Enables the overlay behavior blocked by rdar://problem/27539951.
DougGregor
force-pushed
the
custom-anyhashable-nsmeasurement
branch
from
87ab304 to
fa4331b
Compare
|
@swift-ci please smoke test and merge |
|
@gribozavr updated, thank you! |
| NSMeasurement(doubleValue: 100, unit: UnitLength.kilometers), | ||
| ] | ||
| let anyHashables = values.map(AnyHashable.init) | ||
| expectEqual(Measurement.self, type(of: anyHashables[0].base)) |
There was a problem hiding this comment.
LGTM with an explicit generic type parameter on Measurement in the assertion.
| } | ||
|
|
||
| func test_AnyHashableCreatedFromNSMeasurement() { | ||
| if #available(iOS 8.0, *) { |
There was a problem hiding this comment.
This availability check doesn't make sense to me - NSMeasurement is new in iOS 10 and OS X 10.12.
There was a problem hiding this comment.
Good catch; this whole test is already iOS 10/macOS 10.12. Fixed in a subsequent commit.
|
@swift-ci please smoke test and merge |
[pull] swiftwasm-release/5.7 from release/5.7
Enable custom AnyHashable representation for NSMeasurement
Resolves rdar://problem/27539951.