[3.0] Fix casting to Measurement and introduce custom AnyHashable support #4801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type checker had some logic for performing specific checking for explicit bridging casts of generic types based on knowledge of Array/Dictionary/Set, but pretended no other bridged generic types existed. That's incorrect now; simply require them to match exactly. Fixes rdar://problem/27539951. (cherry picked from commit 6b91c5b)
…easurement Enables the overlay behavior blocked by rdar://problem/27539951. (cherry picked from commit fa4331b)
…e test. (cherry picked from commit 8fc8a5e)
|
@swift-ci please test macOS |
aaditya-chandrasekhar
pushed a commit
to val-verde/swift
that referenced
this pull request
Sep 30, 2022
[pull] swiftwasm-release/5.7 from release/5.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash-on-valid in the compiler where we had an 'unreachable' assertion on valid code that attempts to perform a bridging cast from
NSMeasurementtoMeasurement. While that fix is good in an of itself, it also unblocked customAnyHashablesupport forNSMeasurement.Resolves rdar://problem/27539951.