Skip to content

[build-script] Add --skip-build-sourcekit #4806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

modocache
Copy link
Contributor

Expose the CMake SWIFT_BUILD_SOURCEKIT option at the build-script and build-script-impl layer. This allows SourceKit builds to be enabled/disabled via the command-line:

utils/build-script --skip-build-sourcekit

Since SourceKit only builds on macOS at the moment, automatically add --skip-build-sourcekit to non-macOS host builds.

Resolves SR-2653.

Expose the CMake "SWIFT_BUILD_SOURCEKIT" option at the build-script and
build-script-impl layer. This allows SourceKit builds to be
enabled/disabled via the command-line:

```
utils/build-script --skip-build-sourcekit
```

Since SourceKit only builds on macOS at the moment, automatically add
`--skip-build-sourcekit` to non-macOS host builds.
@gribozavr
Copy link
Contributor

Thanks for your PR, but this is not exactly how --skip-* flags are supposed to work. --skip-build-* is supposed to not interfere with the configuration step, and just skip the build step. For example, you should be able to run just the configuration step by specifying all --skip-* flags.

I'd suggest that instead you add a --sourcekit flag, and allow specifying a 0 argument to disable it. This will be consistent with --lldb, --swiftpm etc.

@modocache
Copy link
Contributor Author

I sent this because I thought it was needed for building the runtime for Android on macOS, but I managed to be able to do that with #4972. I still think being able to flip SourceKit on or off would be useful, but I'll close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants