[Scope map] Local types and functions are visible in the enclosing braces #4816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aces. As in non-local scopes, local types and functions are generally visible anywhere within enclosing braces, and it is up to capture analysis to determine whether these entities attempt to capture an entity that isn't guaranteed to be available.
|
@swift-ci please smoke test and merge |
aaditya-chandrasekhar
pushed a commit
to val-verde/swift
that referenced
this pull request
Sep 30, 2022
[pull] swiftwasm-release/5.7 from release/5.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in non-local scopes, local types and functions are generally
visible anywhere within enclosing braces, and it is up to capture
analysis to determine whether these entities attempt to capture an
entity that isn't guaranteed to be available.
This brings us down to ~11 failures in the normal test suite when using ASTScope-based unqualified name lookup in lieu of FindLocalVal-based unqualified name lookup. (Plus a pile of crashers in the validation tests)