Skip to content

[swift-3.0-branch] Foundation: add a custom AnyHashable representation for NSSet #4822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2016

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Sep 16, 2016

  • Explanation: Add a custom AnyHashable representation for NSSet
  • Scope of Issue: Fixes the bridging in case where NSSet is a key in a Dictionary
  • Origination:
  • Risk: Minimal
  • Reviewed By: Doug Gregor
  • Testing: Existing test suite.
  • Directions for QA: N/A

PR against master: #4810
rdar://problem/28330040

@moiseev moiseev changed the title Foundation: add a custom AnyHashable representation for NSSet [swift-3.0-branch] Foundation: add a custom AnyHashable representation for NSSet Sep 16, 2016
@moiseev
Copy link
Contributor Author

moiseev commented Sep 16, 2016

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 14d2046a4f0d13197758c694a1e9cf886c96b3de
Test requested by - @moiseev

@tkremenek
Copy link
Member

This fails on macOS:

17:20:23 
/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-swift-3.0-branch/swift/test/1_stdlib/NSSetAPI.swift:65:7: error: use of unresolved identifier 'expectNotNil'
17:20:23     = expectNotNil((anyHashable.base as! Set<AnyHashable>).first!) {
17:20:23       ^~~~~~~~~~~~
17:20:23 StdlibUnittest.expectNotEqual:1:13: note: did you mean 'expectNotEqual'?
17:20:23 public func expectNotEqual<T : Equatable>(_ expected: T, _ actual: T, _ message: @autoclosure () -> String = default, stackTrace: StdlibUnittest.SourceLocStack = default, showFrame: Bool = default, file: String = #file, line: UInt = #line)
17:20:23             ^
17:20:23 StdlibUnittest.expectNotEqual:1:13: note: did you mean 'expectNotEqual'?
17:20:23 public func expectNotEqual<T : Equatable>(_ expected: T?, _ actual: T?, _ message: @autoclosure () -> String = default, stackTrace: StdlibUnittest.SourceLocStack = default, showFrame: Bool = default, file: String = #file, line: UInt = #line)

@gribozavr
Copy link
Contributor

@moiseev expectNotNil => expectNotEmpty would fix this.

@moiseev moiseev force-pushed the nsset-anyhashable-ccc branch from 14d2046 to 9736e5f Compare September 16, 2016 17:58
@moiseev
Copy link
Contributor Author

moiseev commented Sep 16, 2016

@swift-ci Please test

@tkremenek
Copy link
Member

@swift-ci test linux

@tkremenek
Copy link
Member

@swift-ci test macOS

@tkremenek tkremenek merged commit 0cca666 into swiftlang:swift-3.0-branch Sep 17, 2016
@moiseev moiseev deleted the nsset-anyhashable-ccc branch September 19, 2016 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants