Sema: Fix crash when attempting to diagnose a contextual conversion o… #4879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slavapestov
commented
Sep 20, 2016
slavapestov
commented
- Description: Fixes a crash on invalid code when we should produce a diagnostic.
- Risk: Low, it's just a small change to a diagnostic path. The worst outcome here is a regression in QoI if we bail out too eagerly.
- Tested: New test added, used to produce a bad diagnostic followed by a crash, now produces a diagnostic explaining the actual problem.
- Reviewed by: @jrose-apple
- JIRA: https://bugs.swift.org/browse/SR-2592, Radar: rdar://problem/28141573
…f an ambiguous expression The fixits call back into the type checker via typeCheckCheckedCast(), which sets up a new constraint system. As a result we would hit assertions by introducing type variables from a previous "generation". It seems that if we bail out of this code path altogether, we get a better diagnostic -- in the provided test, it complains about an ambiguous member to '.value', rather than not being able to convert _? to V?. Fixes <https://bugs.swift.org/browse/SR-2592>.
|
@swift-ci Please test OS X |
|
Note: @jrose-apple already ACKd this over chat. |
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 7, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.