Skip to content

[gardening] Fix recently introduced typos. #4884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2016
Merged

[gardening] Fix recently introduced typos. #4884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/SILOptimizer/Analysis/EscapeAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,7 +1156,7 @@ bool EscapeAnalysis::buildConnectionGraphForDestructor(
}
// If Ty is a an optional, its deallocation is equivalent to the deallocation
// of its payload.
// TODO: Generalize it. Destructor of an aggrgate type is equivalent to calling
// TODO: Generalize it. Destructor of an aggregate type is equivalent to calling
// destructors for its components.
while (Ty.getSwiftRValueType()->getAnyOptionalObjectType())
Ty = M.Types.getLoweredType(Ty.getSwiftRValueType()
Expand Down Expand Up @@ -1312,7 +1312,7 @@ void EscapeAnalysis::analyzeInstruction(SILInstruction *I,

if (isa<StrongReleaseInst>(I) || isa<ReleaseValueInst>(I)) {
// Treat the release instruction as if it is the invocation
// of a deinit funciton.
// of a deinit function.
if (RecursionDepth < MaxRecursionDepth) {
// Check if the destructor is known.
auto OpV = cast<RefCountingInst>(I)->getOperand(0);
Expand Down
8 changes: 4 additions & 4 deletions test/SILOptimizer/escape_analysis.sil
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1338,7 +1338,7 @@ bb0(%0 : $X):
return %1 : $()
}

// Escape analysis should analyze the implcit destructor call which may
// Escape analysis should analyze the implicit destructor call which may
// happen due to strong_release and figure out that the object will not
// globally escape.
// CHECK-LABEL: CG of check_non_escaping_implicit_destructor_invocation_via_strong_release
Expand All @@ -1353,7 +1353,7 @@ bb0:
return %3 : $()
}

// Escape analysis should analyze the implcit destructor call which may
// Escape analysis should analyze the implicit destructor call which may
// happen due to strong_release and figure out that the object will not
// globally escape.
// CHECK-LABEL: CG of check_non_escaping_implicit_destructor_invocation_via_release_value
Expand All @@ -1368,7 +1368,7 @@ bb0:
return %3 : $()
}

// Escape analysis should analyze the implcit destructor call which may
// Escape analysis should analyze the implicit destructor call which may
// happen due to strong_release and figure out that the object will
// globally escape.
// CHECK-LABEL: CG of check_escaping_implicit_destructor_invocation_via_strong_release
Expand All @@ -1385,7 +1385,7 @@ bb0:
return %3 : $()
}

// Escape analysis should analyze the implcit destructor call which may
// Escape analysis should analyze the implicit destructor call which may
// happen due to strong_release and figure out that the object will
// globally escape.
// CHECK-LABEL: CG of check_escaping_implicit_destructor_invocation_via_release_value
Expand Down