ABCOpts: Bail out if we don't know how-to hoist an array operation #4885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of assuming we see only certain forms IR. rdar://28204253 (cherry picked from commit 3c755e3)
|
@eeckstein Can you review? |
|
@swift-ci Please test. |
|
LGTM |
eeckstein
approved these changes
Sep 20, 2016
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Array bounds checks assumed to see certain forms of SIL and only asserted them to be expected. This causes crashes when this assumption is broken.
Instead of asserting the forms it can handle check and bail if the expected forms are not encountered.
Scope: This issue was hit on one project so far.
Risk: Low, we bail out if the IR is not of the expected form.
Tested: SIL regression test added.
Radar: rdar://problem/28204253