Skip to content

[SourceKit] Align closures inside function arguments. (3.0) #4890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2016
Merged

[SourceKit] Align closures inside function arguments. (3.0) #4890

merged 1 commit into from
Sep 21, 2016

Conversation

nkcsgexi
Copy link
Contributor

@nkcsgexi nkcsgexi commented Sep 20, 2016 •
edited
Loading

  • Explanation: When indenting a function call taking multiple closures across several lines, the users expect to see these closures align with each other like siblings. This patch adjust our indentation algorithm to incorporate this special case.
  • Reviewer: Argyrios
  • Scope of Issue: A special case of Indentation; SourceKit.
  • Risk: Very Low.
  • Testing: A regression test was added.

@nkcsgexi nkcsgexi added this to the Swift 3.0 milestone Sep 20, 2016
@nkcsgexi
Copy link
Contributor Author

@swift-ci Please test OS X platform

@akyrtzi
Copy link
Contributor

akyrtzi commented Sep 21, 2016

LGTM!

@tkremenek tkremenek merged commit 6e08a45 into swiftlang:swift-3.0-branch Sep 21, 2016
MaxDesiatov pushed a commit that referenced this pull request Sep 7, 2023
@kateinoigakukun
Merge pull request #4890 from swiftwasm/main
290e083 
[pull] swiftwasm from main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Swift 3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nkcsgexi @akyrtzi @tkremenek