Use the existing '.rawValue' fix-it to handle unwrapping objects too. #4910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy/paste issue, most likely.
We could probably make this even more general, but this specifically avoids trying to insert an "as AnyObject" fix-it, which will now work but probably produce an incorrect result. This comes up when working with swift_newtype wrappers of CF types being passed to CFTypeRef parameters. rdar://problem/26678862
|
@akyrtzi, can you review this? Are you okay with me hijacking your and @slavapestov's logic for this? @swift-ci Please test |
|
Build failed |
|
LGTM! |
|
Build failed |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Sep 22, 2016
…pe-rawValue Use the existing '.rawValue' fix-it to handle unwrapping objects too. rdar://problem/26678862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could probably make this even more general, but this specifically avoids trying to insert an "as AnyObject" fix-it, which will now work but probably produce an incorrect result. This comes up when working with
swift_newtypewrappers of CF types being passed to CFTypeRef parameters.While here, also fix a copy/paste issue with the existing logic.
rdar://problem/26678862