Add empty parens to var-to-function renames, take two. #4938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This time, propagate the decl marked deprecated or unavailable through to the fix-it, so we can be sure it's a var. https://bugs.swift.org/browse/SR-1649
|
Dispatch failed here in an unrelated issue. @das, @dgrove-oss? @swift-ci Please smoke test Linux platform |
|
The dispatch test failure looks to be a timeout: a piece of work that was expected to complete in less than 1 second failed to do so and the test failed as a result. Very likely a transient load on the CI machine caused the failure. |
|
@harlanhaskins, want to review this since Xi's busy? |
|
Sorry for dropping the review, LGTM! |
|
Ha -- I was just about to click over and LGTM it. |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Sep 23, 2016
This time, propagate the decl marked deprecated or unavailable through to the fix-it, so we can be sure it's a var. https://bugs.swift.org/browse/SR-1649 (cherry picked from commit d89c232)
aaditya-chandrasekhar
pushed a commit
to val-verde/swift
that referenced
this pull request
Sep 30, 2022
[pull] swiftwasm-release/5.7 from release/5.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @harlanhaskins' #3947, reverted in #4930. This time, propagate the decl marked deprecated or unavailable through to the fix-it, so we can be sure it's a var.
SR-1649