[build-presets] Skip libdispatch tests for XCTest #4942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `corelibs-xctest` preset is one that swift-corelibs-xctest contributors could use locally to quickly ensure that XCTest builds and its tests pass. The libdispatch tests add a significant amount of time to this preset, so remove them.
|
@swift-ci please smoke test and merge |
|
Looks like an unrelated build failure on macOS, due to a stale build of CoreImage on the CI server. |
|
@swift-ci please test macOS |
|
@shahmishal Oops! I think "please test macOS" above triggered a "Test and Merge (smoke test)" CI job. Is this a bug? |
|
Build failed |
|
I think it was triggered due to this comment:
|
|
Oh, my bad. I was looking at two other pull requests I submitted and must have gotten confused! 😅 Sorry for taking your time! |
|
@swift-ci please smoke test |
|
This has zero impact on CI, so I'm going to go ahead and merge. |
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 7, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
corelibs-xctestpreset is one that swift-corelibs-xctest contributors could use locally to quickly ensure that XCTest builds and its tests pass. The libdispatch tests add a significant amount of time to this preset, so remove them.