Don't use construction to convert literals in rawValue fix-it. #4943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrose-apple
commented
Sep 23, 2016
jrose-apple
commented
- Explanation: We have a fix-it for when the user tries to pass a bare value to a type that's RawRepresentable with that type, as long as it's a type that's expressible-by-literal. The fix-it is smart enough to insert an extra converting construction if the raw value type doesn't match exactly, but it's not smart enough to omit that if the bare value is itself a literal (and would be inferred to the correct type). Fix that by just checking for a literal expression before inserting the conversion.
- Scope: Affects failure diagnosis involving RawRepresentable types.
- Issue: rdar://problem/26681232
- Reviewed by: @nkcsgexi
- Risk: Very low.
- Testing: Added a compiler regression test, verified that the originally reported case now gets useful fix-its.
…lang#4934) Input: panel.styleMask = 8345 Old output: panel.styleMask = NSWindowStyleMask(rawValue: UInt(8345)) New output: panel.styleMask = NSWindowStyleMask(rawValue: 8345) rdar://problem/26681232 (cherry picked from commit b9e1d4c)
|
@swift-ci Please test |
|
Thanks for taking this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.