[3.0] [CloudKit overlay] Work around an NSError bridging issue specific to CKError #4960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CKError. While here, fix up the type signature of CKError.partialErrorsByItemID; it doesn't make sense to use NSObject now that we have AnyHashable. Fixes rdar://problem/27936562. (cherry picked from commit 661df18)
|
@swift-ci please test macOS |
|
@moiseev , can you take a look at this awful PR? |
|
Build failed |
|
This failed somewhere in StdlibUnittest... which wasn't touched by this change at all. |
|
@swift-ci please test |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While here, fix up the type signature of
CKError.partialErrorsByItemID; it doesn't make sense to useNSObjectnow that we have
AnyHashable.This is an awful PR; it narrowly works around an issue with a specific API, and omits a test case because the testing harness isn't set up to handle testing frameworks that require entitlements. I've manually verified that this workaround makes the APIs usable and am looking into the issue of
NSErrorsubclasses more generally.Resolves rdar://problem/27936562.
(cherry picked from commit 661df18)