Assert that the main source file name is non-empty. #4963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Darwin linker won't process the debug info if the source file name is invalid so there is no point in having a fallback implemented there. <rdar://problem/25130236>
|
@swift-ci please test and merge |
|
@swift-ci please smoke test OS X platform and merge |
|
@swift-ci please smoke test OS X platform |
|
@swift-ci test OS X platform |
|
This broke my PR testing. What happened? |
|
@adrian-prantl , should we have someone force merge your revert to get PR testing working again? |
|
@atrick that would be a good idea, thanks! |
|
@jrose-apple not sure yet. It supposedly passed a full macOS platform test but the assertion triggered in your PR while building the macosx stdlib, which doesn't make sense. I'll update this PR once I figured out what happened here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Darwin linker won't process the debug info if the source file name
is invalid so there is no point in having a fallback implemented there.
rdar://problem/25130236