Skip to content

[3.0] Dependency fixes for overlays #4964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2016

Conversation

jckarter
Copy link
Contributor

Try to fix build races.

jckarter and others added 3 commits September 23, 2016 10:45
CoreImage used to be part of QuartzCore on macOS, so QuartzCore
automatically re-exports it.
Things that depend on MapKit and QuartzCore also need to be updated.
@jckarter
Copy link
Contributor Author

@swift-ci Please test OS X

@jckarter
Copy link
Contributor Author

@atrick Do these look good for 3.0, assuming it builds cleanly?

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Swift 3!

@jckarter jckarter changed the title Dependency fixes for overlays [3.0] Dependency fixes for overlays Sep 23, 2016
@atrick
Copy link
Contributor

atrick commented Sep 23, 2016

@tkremenek please merge.

@jrose-apple
Copy link
Contributor

Or @ematejska, perhaps? This should clear up build issues we're seeing on the branch without having any affect on functionality.

@tkremenek tkremenek merged commit 487c5da into swiftlang:swift-3.0-branch Sep 23, 2016
MaxDesiatov pushed a commit that referenced this pull request Sep 7, 2023
[pull] swiftwasm from main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants