SR-2747: Recommend type(of:) instead of .dynamicType #4974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching this and thanks for the patch! I think I'd mildly prefer just naming this operation like a Swift function: |
|
|
|
Agreed on the |
|
Fixed the issue. I used |
|
Found where it comes from. If it’s better that they’re consistent I’m happy to change the other instance(s) of |
SlaunchaMan
changed the title
xwu
reviewed
Sep 24, 2016
| _ = NSObject.`class`() // expected-error {{'class()' is unavailable in Swift: use 'self' instead}} | ||
| _ = obj.`class`!() // expected-error {{'class()' is unavailable in Swift: use 'dynamicType' instead}} | ||
| _ = obj.`class`!() // expected-error {{'class()' is unavailable in Swift: use 'type(of:' instead}} |
|
@swift-ci please smoke test |
|
Any more thoughts on this? |
|
LGTM! |
|
Thanks, Jeff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use
.class()from Objective-C, the compiler recommended using.dynamicTypeinstead, which has been deprecated in favor oftype(of:).Resolves SR-2747.