Skip to content

[swift-3.0-branch] Declaring MAP_FAILED #4975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2016
Merged

[swift-3.0-branch] Declaring MAP_FAILED #4975

merged 1 commit into from
Sep 23, 2016

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Sep 23, 2016

  • Explanation: Export MAP_FAILED constant
  • Scope of Issue: Purely additive change, that will simplify using mmap() library function
  • Origination: Clang importer is unable to handle ((void *)-1)
  • Risk: Minimal
  • Reviewed By: Doug Gregor
  • Testing: Ran the existing test suite.
  • Directions for QA: N/A

rdar://problem/28454321

[overlay] Declaring MAP_FAILED
a1c8a7a 
Clang importer is unable to handle `((void *)-1)`, therefore manually
declaring the said constant in both Darwin and Glibc modules.

rdar://problem/26689135
@moiseev
Copy link
Contributor Author

moiseev commented Sep 23, 2016

@swift-ci Please smoke test

@moiseev
Copy link
Contributor Author

moiseev commented Sep 23, 2016

LGTMed by Doug here

@tkremenek tkremenek merged commit f2c565c into swiftlang:swift-3.0-branch Sep 23, 2016
@moiseev moiseev deleted the map-failed-ccc branch September 23, 2016 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tkremenek tkremenek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moiseev @tkremenek