SR-2709: @available(swift, ...) #4985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
added
the
swift evolution pending discussion
CodaFi
reviewed
Sep 25, 2016
| /// The entity might be unavailable, because it was introduced after | ||
| /// the minimum version. | ||
| /// The entity might be unavailable at runtime, because it was introduced | ||
| /// after the requested minimum platform version. |
There was a problem hiding this comment.
Nit: You say "platform or language" version above but "platform" here.
There was a problem hiding this comment.
That's correct; potential-availability only applies to platform, not language.
| @@ -618,21 +619,24 @@ class AvailableAttr : public DeclAttribute { | |||
| /// Indicates when the symbol was obsoleted. | |||
| const Optional<clang::VersionTuple> Obsoleted; | |||
|
|
|||
| /// Indicates if the declaration has unconditional availability. | |||
| const UnconditionalAvailabilityKind Unconditional; | |||
| /// Indicates if the declaration has plafrorm-agnostic availability. | |||
graydon
force-pushed
the
SR-2709-available-swift-version
branch
2 times, most recently
from
dd3489d to
87bce60
Compare
|
@swift-ci Please smoke test |
jrose-apple
reviewed
Sep 28, 2016
| "'swift' version-availability must be specified alone", ()) | ||
|
|
||
| ERROR(pound_available_swift_not_allowed, none, | ||
| "Swift language version checks not allowed in #available(...)", ()) |
There was a problem hiding this comment.
Please add tests for these diagnostics!
jrose-apple
reviewed
Sep 28, 2016
| @@ -3104,6 +3104,10 @@ ERROR(availability_decl_unavailable_in_swift_msg, none, | |||
| NOTE(availability_marked_unavailable, none, | |||
| "%0 has been explicitly marked unavailable here", (DeclName)) | |||
|
|
|||
| NOTE(availability_introduced_in_swift, none, | |||
| "%0 was introduced in swift %1", | |||
There was a problem hiding this comment.
Nitpick: "Swift" should be capitalized here.
jrose-apple
reviewed
Sep 28, 2016
| // FIXME: Use of the platformString here is non-awesome for application | ||
| // extensions. | ||
| diagnose(D, diag::availability_obsoleted, Name, | ||
| Attr->prettyPlatformString(), | ||
| (Attr->isLanguageVersionSpecific() ? | ||
| "swift" : Attr->prettyPlatformString()), |
graydon
force-pushed
the
SR-2709-available-swift-version
branch
from
87bce60 to
220fc24
Compare
graydon
added
swift evolution approved
|
@swift-ci please test and merge |
|
@swift-ci please smoke test and merge |
|
@swift-ci please test and merge |
|
@swift-ci please smoke test |
|
@swift-ci please test and merge |
|
@swift-ci please clean test and merge |
UnconditionalAvailabilityKind => PlatformAgnosticAvailabilityKind
::UnavailableInCurrentSwift => ::SwiftVersionSpecific
Plus a couple related method renamings. Prep work for SR-2709.
graydon
force-pushed
the
SR-2709-available-swift-version
branch
from
dc7a5ca to
3ca7555
Compare
|
@swift-ci Please smoke test and merge |
|
Looks like this is implemented — I can mark it as such in swift-evolution. Would that be under Swift 4 or Swift 3.1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses SR-2709, and corresponds to the proposal currently under review in
https://lists.swift.org/pipermail/swift-evolution-announce/2016-September/000286.html
It's a relatively minor extension to the
@available(...)system to permit availability testingby swift language version. A companion to the previous PR #4826 that enables command-line
backwards compatibility adjustment of the compiler's effective language version.
I'm posting here for implementation review; it should not be merged until the evolution proposal
has been reviewed and approved by the community. I'll amend here to track any changes that
come up during that discussion.
Resolves SR-2709.