Small generate harness improvements #4993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…do not get a diff due to sorting differences.
… for the harness, sort the single-source files to give a deterministic ordering.
|
@swift-ci Please python lint |
|
@swift-ci Please smoke test and merge |
|
The python lint failures were not from these commits. |
|
@swift-ci Please smoke test OS X platform |
|
Adrian's fix landed so resmoke testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a NFC change that ensures that the generated file does not cause diffs due to sorting.
There are still problems with the generated harness not creating imports for unittests. So I expicitly did not rerun it as apart of this patch.
As a more meta-comment, we should probably change the swift benchmarks at some point into a swiftpm project that is an external build of the swift compiler project. I still think it should be in tree to ensure we do not break it = ).