[runtime] Refactor binary section data loading into separate file #5046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move OS specific libdl calls from ProtocolConformance.cpp into SectionData.cpp - Remove duplicate defintions also contained in MetadataLookup.cpp
|
@swift-ci Please test |
|
Title is a bit misleading. Removing the |
moiseev
changed the title
|
Not needed as #5846 has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all of the OS specific functions and definitions that load section data using the dynamic loader into its own file, cleaning up MetadataLookup and ProtocolConformance. This is just a cleanup of the code to make it easier to add other object formats etc and potentially static linking at some point (see #4754)
Tested on Linux and MacOS.
SectionData.cpp