IRGen: emitObjCMetadataRef needs to handle weakly linked Objective C … #5049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test os x platform |
aschwaighofer
force-pushed
the
fix_irgen_emitObjCMetadataRef
branch
from
3a605b7 to
6b32dd2
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
@jckarter Can you review this? I would also like to pull this into swift-3.0-branch. |
|
Looks good as a quick fix. It might be better for code size and robustness to move the null check into the |
…ked classes rdar://28203571
|
Good point. |
aschwaighofer
force-pushed
the
fix_irgen_emitObjCMetadataRef
branch
from
6b32dd2 to
d3ef6f7
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…classes which maybe null
WIP, test case to follow ...
rdar://28203571