[APINotes] Fix mis-annotated error code enums. #5051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrose-apple
commented
Sep 28, 2016
jrose-apple
commented
- Explanation: Our API notes sidecar data has an annotation that can be used to associate an enum representing error codes with an NSError domain string constant. However, in the mechanical process of finding all such error code enums, we messed up and accidentally renamed them to the domain constant instead. This change fixes that.
- Scope: Only affects users of these particular errors.
- Issue: rdar://problem/28507946
- Reviewed by: @DougGregor
- Risk: Medium-low. Someone could have written code using the "wrong" name, but it's clearly incorrect, and since we haven't seen complaints about the unexpected renames, it's possible there isn't any such code.
- Testing: Manually verified that the enums import as Swift errors now.
Some files accidentally /renamed/ the enums using SwiftName rather than associating them with an error domain constant. Amazingly, we've gotten no complaints about this. (cherry picked from commit 3e6fa8b)
|
@swift-ci Please test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.