[Parser] Fix right angle location in erroneous parameter list #5099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If '>' could not be found, the parser should return the location of the last token parsed, instead of the current token. Previously, it may causes ASTVerifier error "child source range not contained within its parent" in some cases.
|
@swift-ci Please smoke test |
|
Nice catch! Does this resolve any compiler crashers? :) |
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
>could not be found, theskipUntilGreaterInTypeListshould return the location of thelast token consumed, instead of the current token.
Previously, it may cause ASTVerifier error
"child source range not contained within its parent"in some cases. Or highlight overrun in diagnostics:Resolves
compiler_crashers/28429-swift-decl-print.swift.