Fix quarantineProperty in URLResourceValues #5125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSURL has an odd behavior around the quarantine dictionary URL resource value - if you want to clear it, you should pass NSNull instead of the NSDictionary. We need to accomodate that in the overlay code with a special case. <rdar://problem/28575806> Cannot remove Quarantine attribute in Swift 3
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSURL has an odd behavior around the quarantine dictionary URL resource value - if you want to clear it, you should pass NSNull instead of the NSDictionary. We need to accomodate that in the overlay code with a special case.
Resolves rdar://problem/28575806 Cannot remove Quarantine attribute in Swift 3