SILCombine: handle upcasts when converting from alloc_ref_dynamic to alloc_ref #5140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge |
gottesmm
requested changes
Oct 5, 2016
|
(btw, the only reason I requested the changes was to stop the merge from the smoke test.) |
…alloc_ref We transform an "alloc_ref_dynamic(metatype @thick $T)" to an "alloc_ref $T" But in some cases there can be an upcast in-between. Now we also do "alloc_ref_dynamic(upcast(metatype @thick $Derived) to $Base)" -> "upcast(alloc_ref $Derived) to $Base" This peephole optimization is needed for the upcoming change of using tail allocated arrays in ManagedBuffer.
eeckstein
force-pushed
the
silcombine-alloc-ref-dynamic
branch
from
502f581 to
bf7ac4a
Compare
gottesmm
approved these changes
Oct 5, 2016
|
Looks great Erik! |
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.