[Gardening] Normalize the way paren types are stripped in Sema. #5163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test. |
|
Technically some of these were unwrapping one level of parentheses, while |
|
The only change I'm not 100% on is the ASTVerifier. The comments in and around the others seem to indicate they intend to strip everything before passing it on. |
|
@DougGregor @slavapestov Can one of you quickly verify I haven't done something strange here? |
CodaFi
force-pushed
the
the-paren-trap
branch
from
7cb95c3 to
002fa08
Compare
|
@swift-ci please smoke test. |
CodaFi
force-pushed
the
the-paren-trap
branch
from
002fa08 to
f59d5cb
Compare
|
@swift-ci please smoke test and merge. |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the can. Noticed we were duplicating the definition of
getWithoutParensin quite a few places while writing #5110.