[CMake] Cross-compiling dylib support on macOS #5165
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling shared libraries from macOS to Linux or Android, specify a .so library suffix, and pass -shared to the linker.
|
@swift-ci Please test |
jrose-apple
reviewed
Oct 6, 2016
| @@ -269,7 +269,7 @@ function(_add_variant_link_flags) | |||
| set(oneValueArgs SDK ARCH BUILD_TYPE ENABLE_ASSERTIONS ANALYZE_CODE_COVERAGE | |||
| DEPLOYMENT_VERSION_IOS RESULT_VAR_NAME ENABLE_LTO LTO_OBJECT_NAME) | |||
| cmake_parse_arguments(LFLAGS | |||
| "" | |||
| "IS_STDLIB" | |||
There was a problem hiding this comment.
This seems wrong. What's special about the stdlib over, say, libSwiftGlibc?
|
Build failed |
|
I'm reducing the scope of my original pull request #4972, to only enable building static libraries. This change isn't necessary to build statically, plus it seems like I'll need a different approach anyway, so I'll close this for now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling shared libraries from macOS to Linux or Android, specify a .so library suffix, and pass -shared to the linker.
This was pulled out of the larger pull request #4972, which addresses SR-1362.