[Parse] Don't use tok::unknown as a dummy token #5171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@lattner Can you review this? |
Use tok::NUM_TOKENS instead. tok::unknown can easily appear in source code. For instance `skipUntil(tok::eof)` did not work as expected, because that was `skipUntil(tok::eof, tok::unknown)` hence does stop at error tokens such as `0xG` (invalid hex number literal). Revert 2abc92b, since that was accidental side-effect of 4511803. Forward references are not allowed actually.
|
@swift-ci Please smoke test |
|
LGTM! This is a great idea. |
lattner
approved these changes
Oct 7, 2016
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
tok::NUM_TOKENSinstead.tok::unknowncan easily appear in source code.For instance
skipUntil(tok::eof)did not work as expected, because that wasskipUntil(tok::eof, tok::unknown)hence does stop at error tokens such as0xG(invalid hex number literal).Revert 2abc92b, since that was accidental side-effect of 4511803.
Forward references are not allowed at top level, actually.