[CMake] swiftSIL needs intrinsics_gen #5192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftSIL headers include llvm/IR headers which depend on the tablegen generated intrinsics and attributes headers.
|
@swift-ci please smoke test and merge |
|
Looks fine to me. In the future, rather than relying on variables not being set in these cases like previously, can you always just check the standalone flag like you did here. It seems a cleaner expression of intent and less likely to result in bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiftSIL headers include llvm/IR headers which depend on the tablegen
generated intrinsics and attributes headers.