Multiple fixes to fix the release builds #5193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
…cializations static. NFC. There is no reason to create this constant set dynamically again and again.
Provide proper copy constructors to ensure correctness. And forbid assignments between SILOpenedArchetypesTracker objects. Until now those copy constructors were automatically generated by the C++ compiler, but it was wrong, because two SILOpenedArchetypesTracker objects would sometimes share their internal representations, which resulted in a use-after-destruction bugs.
According to the documentation, llvm::function_ref is better suited for function parameters taking closures. But in this case we need to store a closure in the callback field and then invoke it multiple times. Therefore it is more appropriate to use std::function for this purpose.
swiftix
force-pushed
the
wip-sil-opened-archetypes-tracker-fixes
branch
from
ca70050 to
6c71745
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Fixes rdar://28684618
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 3 small fixes that fix the release build.
The fixes mostly address the use-after-destruction errors.
rdar://28678981