[SyntaxModel] Improve the performance of searching URLs in comments #5214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions. Keywords like 'let' can serve as argument labels. When they do so, we should highlight them as identifiers instead of keywords. However, the check for this situation seems overly lenient so that when 'let', 'var' appear in conditions of IfStmt or GuardStmt, they are wrongly highlighted as identifiers too. This commit strengthens the checking to preserve keywords' identity in these statements.
protocol name comparisons by looking ahead more characters, NFC. rdar://28298506 Searching URL in doc comments can be expensive. We used to look for every colon as an indicator of potential URLs. However, this is not efficient enough. Suggested by Ben, we further divide protocols into categories so that most protocols can use "://" as an indicator of its existence. Not sure whether this is enough to close the radar, but I believe it is a valuable performance improvement anyway.
|
@swift-ci smoke test |
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 7, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SyntaxModel] When searching URLs in doc comments, reduce the number of protocol name comparisons by looking ahead more characters, NFC. rdar://28298506
rdar://problem/28705426